feat(cli): reduce redundancy on context to cluster flags in command `deployment create` #1156

instamenta · 2025-01-14T11:33:17Z

Description

Removes flag --context-cluster and it's usages, replaces them with data provided from local config deployments.clusters.

Related Issues

Closes #977

…data from flag.deploymentClusters and parsed data inside local config Signed-off-by: instamenta <[email protected]>

github-actions · 2025-01-14T11:35:23Z

Unit Test Results - Linux

1 files ±0 59 suites ±0 4s ⏱️ -1s
233 tests ±0 233 ✅ ±0 0 💤 ±0 0 ❌ ±0
238 runs ±0 238 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 523480d. ± Comparison against base commit 64fbf95.

♻️ This comment has been updated with latest results.

github-actions · 2025-01-14T11:36:45Z

Unit Test Results - Windows

1 files ±0 59 suites ±0 13s ⏱️ -1s
233 tests ±0 233 ✅ ±0 0 💤 ±0 0 ❌ ±0
238 runs ±0 238 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 523480d. ± Comparison against base commit 64fbf95.

♻️ This comment has been updated with latest results.

github-actions · 2025-01-14T12:24:05Z

E2E Test Report

17 files 126 suites 1h 29m 9s ⏱️
258 tests 258 ✅ 0 💤 0 ❌
269 runs 269 ✅ 0 💤 0 ❌

Results for commit 523480d.

♻️ This comment has been updated with latest results.

codacy-production · 2025-01-14T12:24:25Z

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
Report missing for `64fbf95`¹	✅ 65.63%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`64fbf95`)	Report Missing	Report Missing	Report Missing
Head commit (`523480d`)	21721	18221	83.89%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#1156)	32	21	65.63%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

codecov · 2025-01-14T12:25:40Z

Codecov Report

Attention: Patch coverage is 59.37500% with 13 lines in your changes missing coverage. Please review.

Project coverage is 82.99%. Comparing base (9d1a8cb) to head (523480d).
Report is 7 commits behind head on main.

Files with missing lines	Patch %	Lines
src/core/config/remote/listr_config_tasks.ts	46.15%	7 Missing ⚠️
src/commands/cluster/tasks.ts	28.57%	3 Missing and 2 partials ⚠️
src/core/config/local_config.ts	66.66%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1156      +/-   ##
==========================================
+ Coverage   82.89%   82.99%   +0.10%     
==========================================
  Files          78       78              
  Lines       21763    21721      -42     
  Branches     1383     1585     +202     
==========================================
- Hits        18040    18028      -12     
+ Misses       3696     3599      -97     
- Partials       27       94      +67

Files with missing lines	Coverage Δ
src/commands/base.ts	`94.25% <100.00%> (ø)`
src/commands/flags.ts	`75.85% <ø> (+0.20%)`	⬆️
src/commands/mirror_node.ts	`75.61% <100.00%> (ø)`
src/commands/network.ts	`65.79% <100.00%> (ø)`
src/core/config/remote/remote_config_manager.ts	`76.27% <100.00%> (ø)`
src/core/templates.ts	`77.77% <100.00%> (+5.43%)`	⬆️
src/core/config/local_config.ts	`65.86% <66.66%> (+0.13%)`	⬆️
src/commands/cluster/tasks.ts	`88.00% <28.57%> (-0.84%)`	⬇️
src/core/config/remote/listr_config_tasks.ts	`65.97% <46.15%> (-1.05%)`	⬇️

... and 15 files with indirect coverage changes

src/commands/deployment.ts

jeromy-cannon

@instamenta ,

some changes:

check and make sure that K8s testClusterConnection validates that the context exists in the kube config prior to setting it
put K8s testClusterConnection logic in a try/catch block, and if there is a failure revert the context back to its original value.

In this case:

npm run solo -- deployment create -n jeromy --email [email protected] --deployment-clusters solo-e2e

the cluster solo-e2e is what solo will use as an alias to map to a context kind-solo-e2e which I supplied when it prompted me.

The local-config.yaml looks good:

❯ cat local-config.yaml
userEmailAddress: [email protected]
deployments:
  jeromy:
    clusters:
      - solo-e2e
currentDeploymentName: jeromy
clusterContextMapping:
  solo-e2e: kind-solo-e2e

currently, the testClusterConnection fails because solo-e2e isn't a valid context, but it has already updated the kube current context. So, when the program attempts to exit, the release lease fails because k8 is a singleton, and still pointing to context = solo-e2e.

✔ Initialize
  ✔ Acquire lease - lease acquired successfully, attempt: 1/10
↓ Prompt local configuration
❯ Validate cluster connections
  ✖ No active cluster!
◼ Create remote config
*********************************** ERROR *****************************************
failed to read existing leases, unexpected server response of '500' received
***********************************************************************************

…cy-on-context-to-cluster-flags-in-solo-deployment-create # Conflicts: # src/commands/deployment.ts

Signed-off-by: instamenta <[email protected]>

…cy-on-context-to-cluster-flags-in-solo-deployment-create # Conflicts: # src/commands/deployment.ts # src/core/k8.ts

jeromy-cannon

I think maybe something got broke during the merge conflicts, or I missed something, or I started doing something wrong. I'm now getting an error when I try to do this:

❯ kind delete cluster -n solo
Deleting cluster "solo" ...
Deleted nodes: ["solo-control-plane"]
❯ kind create cluster -n solo
Creating cluster "solo" ...
 ✓ Ensuring node image (kindest/node:v1.27.3) 🖼
 ✓ Preparing nodes 📦  
 ✓ Writing configuration 📜 
 ✓ Starting control-plane 🕹️ 
 ✓ Installing CNI 🔌 
 ✓ Installing StorageClass 💾 
Set kubectl context to "kind-solo"
You can now use your cluster with:

kubectl cluster-info --context kind-solo

Have a nice day! 👋
❯ rm -Rf ~/.solo

❯ npm run solo -- init

> @hashgraph/[email protected] solo
> node --no-deprecation --no-warnings dist/solo.js init


******************************* Solo *********************************************
Version                 : 0.33.0
Kubernetes Context      : kind-solo
Kubernetes Cluster      : kind-solo
**********************************************************************************
✔ Setup home directory and cache
✔ Check dependencies [3s]
  ✔ Check dependency: helm [OS: darwin, Release: 23.6.0, Arch: arm64] [3s]
✔ Setup chart manager [1s]
✔ Copy templates in '/Users/user/.solo/cache'


***************************************************************************************
Note: solo stores various artifacts (config, logs, keys etc.) in its home directory: /Users/user/.solo
If a full reset is needed, delete the directory or relevant sub-directories before running 'solo init'.
***************************************************************************************
❯ npm run solo -- deployment create -n jeromy-solo --deployment-clusters kind-solo

> @hashgraph/[email protected] solo
> node --no-deprecation --no-warnings dist/solo.js deployment create -n jeromy-solo --deployment-clusters kind-solo


******************************* Solo *********************************************
Version                 : 0.33.0
Kubernetes Context      : kind-solo
Kubernetes Cluster      : kind-solo
Kubernetes Namespace    : jeromy-solo
**********************************************************************************
✔ Initialize
✔ Setup home directory
✔ Prompt local configuration [6s]
✖ Context kind-solo is not valid for cluster
◼ Validate context
◼ Update local configuration
◼ Validate cluster connections
◼ Create remoteConfig in clusters
*********************************** ERROR *****************************************
Error installing chart solo-deployment
***********************************************************************************
❯ cat ~/.solo/cache/local-config.yaml
userEmailAddress: [email protected]
deployments:
  jeromy-solo:
    clusters:
      - kind-solo
currentDeploymentName: jeromy-solo
clusterContextMapping:
  kind-solo: kind-solo

…cy-on-context-to-cluster-flags-in-solo-deployment-create

…cy-on-context-to-cluster-flags-in-solo-deployment-create # Conflicts: # src/commands/deployment.ts

Signed-off-by: instamenta <[email protected]>

…cluster select Signed-off-by: instamenta <[email protected]>

Signed-off-by: instamenta <[email protected]>

…cy-on-context-to-cluster-flags-in-solo-deployment-create

commit b871e44 Author: Jeromy Cannon <[email protected]> Date: Thu Jan 30 09:30:01 2025 +0000 rename testClusterConnection to testContextConnection Signed-off-by: Jeromy Cannon <[email protected]> commit cb91806 Author: Jeromy Cannon <[email protected]> Date: Thu Jan 30 09:17:17 2025 +0000 fix: fixed merge issue with incorrect license header (#1235) Signed-off-by: Jeromy Cannon <[email protected]> commit 6f43952 Author: Jeromy Cannon <[email protected]> Date: Thu Jan 30 09:04:39 2025 +0000 refactor: minor refactors to K8 setting private and public modifiers (#1234) Signed-off-by: Jeromy Cannon <[email protected]> commit 9c31b6c Author: Jeromy Cannon <[email protected]> Date: Wed Jan 29 23:27:15 2025 +0000 chore: changed license header to SPDX and ran npm run format (#1233) Signed-off-by: Jeromy Cannon <[email protected]> commit b044fcc Author: Ivo Yankov <[email protected]> Date: Wed Jan 29 22:26:19 2025 +0200 feat: Add adminKey flag to node setup command (#1193) Signed-off-by: Ivo Yankov <[email protected]> Signed-off-by: Jeromy Cannon <[email protected]> Co-authored-by: Jeromy Cannon <[email protected]> commit 0c4fec2 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Jan 29 13:58:40 2025 -0600 chore(deps): bump @inquirer/prompts from 7.2.3 to 7.2.4 (#1228) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 18a07b8 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Jan 29 13:57:37 2025 -0600 chore(deps): bump actions/setup-java from 4.6.0 to 4.7.0 (#1229) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 71e56a9 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue Jan 28 15:21:42 2025 -0600 chore(deps-dev): bump typescript-eslint from 8.21.0 to 8.22.0 (#1223) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 1c5212a Author: Jan Milenkov <[email protected]> Date: Tue Jan 28 16:44:28 2025 +0200 chore(lint): manually fixed imports to be consisent (#1219) Signed-off-by: instamenta <[email protected]> commit d460985 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue Jan 28 08:41:01 2025 -0600 chore(deps-dev): bump @types/node from 22.10.10 to 22.12.0 (#1222) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit c448060 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue Jan 28 08:39:44 2025 -0600 chore(deps-dev): bump @typescript-eslint/utils from 8.21.0 to 8.22.0 (#1221) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 83ad04f Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Jan 27 14:54:56 2025 -0600 chore(deps-dev): bump remark-lint-unordered-list-marker-style from 4.0.0 to 4.0.1 (#1214) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit d9a3592 Author: JeffreyDallas <[email protected]> Date: Mon Jan 27 13:23:37 2025 -0600 feat: update solo to support pathPrefix of mirror node importer (#1204) Signed-off-by: Jeffrey Tang <[email protected]> commit 6773955 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Jan 27 12:57:49 2025 -0600 chore(deps-dev): bump remark-lint-list-item-indent from 4.0.0 to 4.0.1 (#1210) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit a31498e Author: Jan Milenkov <[email protected]> Date: Mon Jan 27 20:06:08 2025 +0200 feat(remote-config): instead of keeping just the command and the subcommand inside the remote config keep the flags as passed (#1208) Signed-off-by: instamenta <[email protected]> commit fb69435 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Jan 27 12:00:53 2025 -0600 chore(deps-dev): bump remark-preset-lint-consistent from 6.0.0 to 6.0.1 (#1213) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit ab36894 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Jan 27 12:00:02 2025 -0600 chore(deps-dev): bump eslint from 9.18.0 to 9.19.0 (#1215) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 764db3a Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Jan 27 09:26:12 2025 -0600 chore(deps-dev): bump remark-preset-lint-recommended from 7.0.0 to 7.0.1 (#1212) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 18ee776 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Jan 27 09:25:12 2025 -0600 chore(deps-dev): bump @eslint/js from 9.18.0 to 9.19.0 (#1211) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 809d0ab Author: Jan Milenkov <[email protected]> Date: Mon Jan 27 17:14:36 2025 +0200 feat(remote-config): save reusable solo flags in remoteconfig (#1191) Signed-off-by: instamenta <[email protected]> Signed-off-by: Jeromy Cannon <[email protected]> Signed-off-by: Jan Milenkov <[email protected]> Co-authored-by: Jeromy Cannon <[email protected]> commit 7877d92 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Jan 27 09:03:45 2025 -0600 chore(deps): bump actions/setup-node from 4.1.0 to 4.2.0 (#1209) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 4ab4dd5 Author: Jan Milenkov <[email protected]> Date: Fri Jan 24 18:46:00 2025 +0200 feat(cli): reduce redundancy on context to cluster flags in command `deployment create` (#1156) Signed-off-by: instamenta <[email protected]> commit 80176a3 Author: Hedera Eng Automation <[email protected]> Date: Fri Jan 24 15:39:32 2025 +0000 chore(release): 0.34.0 [skip ci] ## [0.34.0](v0.33.0...v0.34.0) (2025-01-24) ### Features * `solo deployment create` should use the context and cluster provided for where to save the remote config ([#1142](#1142)) ([fe42edd](fe42edd)) * Connect to multicluster deployments and validate remoteConfigs ([#1141](#1141)) ([c78e226](c78e226)) * for v0.59.x or greater set the internal IP address to 127.0.0.1 to avoid an ISS, in config.txt ([#1162](#1162)) ([4ca488b](4ca488b)) * node upgrade command and new e2e tests ([#1133](#1133)) ([1cf5893](1cf5893)) * separate explorer from mirror node install/uninstall ([#1177](#1177)) ([0887fa6](0887fa6)) * solo network destroy should update remote-config ([#1155](#1155)) ([98b028f](98b028f)) * Update solo to load remote config near entry point ([#1176](#1176)) ([473a650](473a650)) ### Bug Fixes * merge error due to change of remote_config_tasks ([#1197](#1197)) ([9d1a8cb](9d1a8cb)) * Normalize mirror node resources path ([#1175](#1175)) ([ab018a7](ab018a7)) * Refactor RemoteConfigTasks class ([#1185](#1185)) ([66cfc4d](66cfc4d)) * remove k8.getKubeConfig ([#1182](#1182)) ([89c557a](89c557a)) * Set mirror node importer startDate ([#1174](#1174)) ([9d9ef53](9d9ef53)) * update hedera explorer chart version and location ([#1188](#1188)) ([0c415ef](0c415ef)) * use "double fork" to invoke port forward within Taskfile ([#1148](#1148)) ([d662d3f](d662d3f)) commit d0a8046 Author: Swirlds Automation <[email protected]> Date: Fri Jan 24 15:37:52 2025 +0000 chore: auto update docs/content/User/StepByStepGuide.md Signed-off-by: Swirlds Automation <[email protected]> commit d60247a Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri Jan 24 08:30:52 2025 -0600 chore(deps-dev): bump @types/node from 22.10.9 to 22.10.10 (#1207) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 28fd81e Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri Jan 24 08:29:42 2025 -0600 chore(deps-dev): bump @types/ws from 8.5.13 to 8.5.14 (#1206) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 64fbf95 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu Jan 23 11:40:40 2025 -0600 chore(deps-dev): bump mocha from 11.0.1 to 11.1.0 (#1200) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 960db04 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu Jan 23 08:19:52 2025 -0600 chore(deps-dev): bump @types/node from 22.10.7 to 22.10.9 (#1199) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 9d1a8cb Author: JeffreyDallas <[email protected]> Date: Wed Jan 22 13:28:24 2025 -0600 fix: merge error due to change of remote_config_tasks (#1197) Signed-off-by: Jeffrey Tang <[email protected]> commit 66cfc4d Author: Ivo Yankov <[email protected]> Date: Wed Jan 22 18:38:35 2025 +0200 fix: Refactor RemoteConfigTasks class (#1185) Signed-off-by: Ivo Yankov <[email protected]> commit 0887fa6 Author: JeffreyDallas <[email protected]> Date: Wed Jan 22 10:38:00 2025 -0600 feat: separate explorer from mirror node install/uninstall (#1177) Signed-off-by: Jeffrey Tang <[email protected]> commit 89c557a Author: Ivo Yankov <[email protected]> Date: Tue Jan 21 16:40:39 2025 +0200 fix: remove k8.getKubeConfig (#1182) Signed-off-by: Ivo Yankov <[email protected]> commit 0c415ef Author: Nathan Klick <[email protected]> Date: Tue Jan 21 07:55:33 2025 -0600 fix: update hedera explorer chart version and location (#1188) Signed-off-by: Nathan Klick <[email protected]> commit 0e236d7 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue Jan 21 07:27:00 2025 -0600 chore(deps-dev): bump @typescript-eslint/utils from 8.20.0 to 8.21.0 (#1190) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jeromy Cannon <[email protected]>

commit 8d614c6 Author: Jeromy Cannon <[email protected]> Date: Thu Jan 30 09:42:17 2025 +0000 rename testClusterConnection to testContextConnection Signed-off-by: Jeromy Cannon <[email protected]> commit 28a4a9f Author: Jeromy Cannon <[email protected]> Date: Thu Jan 30 09:33:00 2025 +0000 Squashed commit of the following: commit b871e44 Author: Jeromy Cannon <[email protected]> Date: Thu Jan 30 09:30:01 2025 +0000 rename testClusterConnection to testContextConnection Signed-off-by: Jeromy Cannon <[email protected]> commit cb91806 Author: Jeromy Cannon <[email protected]> Date: Thu Jan 30 09:17:17 2025 +0000 fix: fixed merge issue with incorrect license header (#1235) Signed-off-by: Jeromy Cannon <[email protected]> commit 6f43952 Author: Jeromy Cannon <[email protected]> Date: Thu Jan 30 09:04:39 2025 +0000 refactor: minor refactors to K8 setting private and public modifiers (#1234) Signed-off-by: Jeromy Cannon <[email protected]> commit 9c31b6c Author: Jeromy Cannon <[email protected]> Date: Wed Jan 29 23:27:15 2025 +0000 chore: changed license header to SPDX and ran npm run format (#1233) Signed-off-by: Jeromy Cannon <[email protected]> commit b044fcc Author: Ivo Yankov <[email protected]> Date: Wed Jan 29 22:26:19 2025 +0200 feat: Add adminKey flag to node setup command (#1193) Signed-off-by: Ivo Yankov <[email protected]> Signed-off-by: Jeromy Cannon <[email protected]> Co-authored-by: Jeromy Cannon <[email protected]> commit 0c4fec2 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Jan 29 13:58:40 2025 -0600 chore(deps): bump @inquirer/prompts from 7.2.3 to 7.2.4 (#1228) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 18a07b8 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Jan 29 13:57:37 2025 -0600 chore(deps): bump actions/setup-java from 4.6.0 to 4.7.0 (#1229) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 71e56a9 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue Jan 28 15:21:42 2025 -0600 chore(deps-dev): bump typescript-eslint from 8.21.0 to 8.22.0 (#1223) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 1c5212a Author: Jan Milenkov <[email protected]> Date: Tue Jan 28 16:44:28 2025 +0200 chore(lint): manually fixed imports to be consisent (#1219) Signed-off-by: instamenta <[email protected]> commit d460985 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue Jan 28 08:41:01 2025 -0600 chore(deps-dev): bump @types/node from 22.10.10 to 22.12.0 (#1222) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit c448060 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue Jan 28 08:39:44 2025 -0600 chore(deps-dev): bump @typescript-eslint/utils from 8.21.0 to 8.22.0 (#1221) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 83ad04f Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Jan 27 14:54:56 2025 -0600 chore(deps-dev): bump remark-lint-unordered-list-marker-style from 4.0.0 to 4.0.1 (#1214) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit d9a3592 Author: JeffreyDallas <[email protected]> Date: Mon Jan 27 13:23:37 2025 -0600 feat: update solo to support pathPrefix of mirror node importer (#1204) Signed-off-by: Jeffrey Tang <[email protected]> commit 6773955 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Jan 27 12:57:49 2025 -0600 chore(deps-dev): bump remark-lint-list-item-indent from 4.0.0 to 4.0.1 (#1210) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit a31498e Author: Jan Milenkov <[email protected]> Date: Mon Jan 27 20:06:08 2025 +0200 feat(remote-config): instead of keeping just the command and the subcommand inside the remote config keep the flags as passed (#1208) Signed-off-by: instamenta <[email protected]> commit fb69435 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Jan 27 12:00:53 2025 -0600 chore(deps-dev): bump remark-preset-lint-consistent from 6.0.0 to 6.0.1 (#1213) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit ab36894 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Jan 27 12:00:02 2025 -0600 chore(deps-dev): bump eslint from 9.18.0 to 9.19.0 (#1215) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 764db3a Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Jan 27 09:26:12 2025 -0600 chore(deps-dev): bump remark-preset-lint-recommended from 7.0.0 to 7.0.1 (#1212) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 18ee776 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Jan 27 09:25:12 2025 -0600 chore(deps-dev): bump @eslint/js from 9.18.0 to 9.19.0 (#1211) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 809d0ab Author: Jan Milenkov <[email protected]> Date: Mon Jan 27 17:14:36 2025 +0200 feat(remote-config): save reusable solo flags in remoteconfig (#1191) Signed-off-by: instamenta <[email protected]> Signed-off-by: Jeromy Cannon <[email protected]> Signed-off-by: Jan Milenkov <[email protected]> Co-authored-by: Jeromy Cannon <[email protected]> commit 7877d92 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Jan 27 09:03:45 2025 -0600 chore(deps): bump actions/setup-node from 4.1.0 to 4.2.0 (#1209) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 4ab4dd5 Author: Jan Milenkov <[email protected]> Date: Fri Jan 24 18:46:00 2025 +0200 feat(cli): reduce redundancy on context to cluster flags in command `deployment create` (#1156) Signed-off-by: instamenta <[email protected]> commit 80176a3 Author: Hedera Eng Automation <[email protected]> Date: Fri Jan 24 15:39:32 2025 +0000 chore(release): 0.34.0 [skip ci] ## [0.34.0](v0.33.0...v0.34.0) (2025-01-24) ### Features * `solo deployment create` should use the context and cluster provided for where to save the remote config ([#1142](#1142)) ([fe42edd](fe42edd)) * Connect to multicluster deployments and validate remoteConfigs ([#1141](#1141)) ([c78e226](c78e226)) * for v0.59.x or greater set the internal IP address to 127.0.0.1 to avoid an ISS, in config.txt ([#1162](#1162)) ([4ca488b](4ca488b)) * node upgrade command and new e2e tests ([#1133](#1133)) ([1cf5893](1cf5893)) * separate explorer from mirror node install/uninstall ([#1177](#1177)) ([0887fa6](0887fa6)) * solo network destroy should update remote-config ([#1155](#1155)) ([98b028f](98b028f)) * Update solo to load remote config near entry point ([#1176](#1176)) ([473a650](473a650)) ### Bug Fixes * merge error due to change of remote_config_tasks ([#1197](#1197)) ([9d1a8cb](9d1a8cb)) * Normalize mirror node resources path ([#1175](#1175)) ([ab018a7](ab018a7)) * Refactor RemoteConfigTasks class ([#1185](#1185)) ([66cfc4d](66cfc4d)) * remove k8.getKubeConfig ([#1182](#1182)) ([89c557a](89c557a)) * Set mirror node importer startDate ([#1174](#1174)) ([9d9ef53](9d9ef53)) * update hedera explorer chart version and location ([#1188](#1188)) ([0c415ef](0c415ef)) * use "double fork" to invoke port forward within Taskfile ([#1148](#1148)) ([d662d3f](d662d3f)) commit d0a8046 Author: Swirlds Automation <[email protected]> Date: Fri Jan 24 15:37:52 2025 +0000 chore: auto update docs/content/User/StepByStepGuide.md Signed-off-by: Swirlds Automation <[email protected]> commit d60247a Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri Jan 24 08:30:52 2025 -0600 chore(deps-dev): bump @types/node from 22.10.9 to 22.10.10 (#1207) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 28fd81e Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri Jan 24 08:29:42 2025 -0600 chore(deps-dev): bump @types/ws from 8.5.13 to 8.5.14 (#1206) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 64fbf95 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu Jan 23 11:40:40 2025 -0600 chore(deps-dev): bump mocha from 11.0.1 to 11.1.0 (#1200) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 960db04 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu Jan 23 08:19:52 2025 -0600 chore(deps-dev): bump @types/node from 22.10.7 to 22.10.9 (#1199) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 9d1a8cb Author: JeffreyDallas <[email protected]> Date: Wed Jan 22 13:28:24 2025 -0600 fix: merge error due to change of remote_config_tasks (#1197) Signed-off-by: Jeffrey Tang <[email protected]> commit 66cfc4d Author: Ivo Yankov <[email protected]> Date: Wed Jan 22 18:38:35 2025 +0200 fix: Refactor RemoteConfigTasks class (#1185) Signed-off-by: Ivo Yankov <[email protected]> commit 0887fa6 Author: JeffreyDallas <[email protected]> Date: Wed Jan 22 10:38:00 2025 -0600 feat: separate explorer from mirror node install/uninstall (#1177) Signed-off-by: Jeffrey Tang <[email protected]> commit 89c557a Author: Ivo Yankov <[email protected]> Date: Tue Jan 21 16:40:39 2025 +0200 fix: remove k8.getKubeConfig (#1182) Signed-off-by: Ivo Yankov <[email protected]> commit 0c415ef Author: Nathan Klick <[email protected]> Date: Tue Jan 21 07:55:33 2025 -0600 fix: update hedera explorer chart version and location (#1188) Signed-off-by: Nathan Klick <[email protected]> commit 0e236d7 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue Jan 21 07:27:00 2025 -0600 chore(deps-dev): bump @typescript-eslint/utils from 8.20.0 to 8.21.0 (#1190) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jeromy Cannon <[email protected]> Signed-off-by: Jeromy Cannon <[email protected]>

removed context cluster flag and it's usages, replaced them all with …

446b8c9

…data from flag.deploymentClusters and parsed data inside local config Signed-off-by: instamenta <[email protected]>

instamenta self-assigned this Jan 14, 2025

instamenta requested review from leninmehedy and a team as code owners January 14, 2025 11:33

instamenta linked an issue Jan 14, 2025 that may be closed by this pull request

reduce redundancy on context to cluster flags in solo deployment create #977

Closed

instamenta requested a review from jeromy-cannon January 14, 2025 11:35

jeromy-cannon reviewed Jan 14, 2025

View reviewed changes

src/commands/deployment.ts Outdated Show resolved Hide resolved

jeromy-cannon requested changes Jan 14, 2025

View reviewed changes

jeromy-cannon added PR: Unresolved Comments A pull request where there are comments and they need to be resolved. PR: Merge Conflicts A pull request that has merge conflicts that need to be resolved. labels Jan 15, 2025

instamenta added 2 commits January 17, 2025 11:06

Merge remote-tracking branch 'origin/main' into 00977-reduce-redundan…

fa53f40

…cy-on-context-to-cluster-flags-in-solo-deployment-create # Conflicts: # src/commands/deployment.ts

fix cluster connection validation logic and conflicts after merge

250c2c1

Signed-off-by: instamenta <[email protected]>

jeromy-cannon added PR: Needs Approval A pull request that needs reviews and approvals. and removed PR: Merge Conflicts A pull request that has merge conflicts that need to be resolved. PR: Unresolved Comments A pull request where there are comments and they need to be resolved. labels Jan 17, 2025

jeromy-cannon previously approved these changes Jan 17, 2025

View reviewed changes

jeromy-cannon added PR: Ready to Merge A pull request that is ready to merge. PR: Merge Conflicts A pull request that has merge conflicts that need to be resolved. and removed PR: Needs Approval A pull request that needs reviews and approvals. labels Jan 17, 2025

Merge remote-tracking branch 'origin/main' into 00977-reduce-redundan…

a05c8ef

…cy-on-context-to-cluster-flags-in-solo-deployment-create # Conflicts: # src/commands/deployment.ts # src/core/k8.ts

instamenta dismissed jeromy-cannon’s stale review via a05c8ef January 20, 2025 08:02

instamenta removed the PR: Merge Conflicts A pull request that has merge conflicts that need to be resolved. label Jan 20, 2025

jeromy-cannon requested changes Jan 21, 2025

View reviewed changes

jeromy-cannon added PR: Unresolved Comments A pull request where there are comments and they need to be resolved. and removed PR: Ready to Merge A pull request that is ready to merge. labels Jan 21, 2025

instamenta added 4 commits January 22, 2025 17:06

Merge remote-tracking branch 'origin/main' into 00977-reduce-redundan…

6bc27cd

…cy-on-context-to-cluster-flags-in-solo-deployment-create

Merge remote-tracking branch 'origin/main' into 00977-reduce-redundan…

121f214

…cy-on-context-to-cluster-flags-in-solo-deployment-create # Conflicts: # src/commands/deployment.ts

cleanup and merge with main

95730b4

Signed-off-by: instamenta <[email protected]>

add logic for selecting cluster inside the select context command

0e006ea

Signed-off-by: instamenta <[email protected]>

instamenta added PR: Unresolved Comments A pull request where there are comments and they need to be resolved. and removed PR: Unresolved Comments A pull request where there are comments and they need to be resolved. labels Jan 22, 2025

lint issues fixed and added additional data to error messages inside …

0449d16

…cluster select Signed-off-by: instamenta <[email protected]>

instamenta requested a review from a team as a code owner January 23, 2025 08:15

instamenta added 3 commits January 23, 2025 15:04

reverted logic for testing context connection back to what's on main

1d633ac

Signed-off-by: instamenta <[email protected]>

fix lint issues and circular dependency

7d7acb2

Signed-off-by: instamenta <[email protected]>

fix failing tests

c5ec1cb

Signed-off-by: instamenta <[email protected]>

instamenta removed the PR: Unresolved Comments A pull request where there are comments and they need to be resolved. label Jan 23, 2025

instamenta added 2 commits January 23, 2025 17:02

Merge remote-tracking branch 'origin/main' into 00977-reduce-redundan…

afddc48

…cy-on-context-to-cluster-flags-in-solo-deployment-create

Merge remote-tracking branch 'origin/main' into 00977-reduce-redundan…

523480d

…cy-on-context-to-cluster-flags-in-solo-deployment-create

jeromy-cannon added the PR: Needs Approval A pull request that needs reviews and approvals. label Jan 24, 2025

jeromy-cannon approved these changes Jan 24, 2025

View reviewed changes

jeromy-cannon merged commit 4ab4dd5 into main Jan 24, 2025
41 of 42 checks passed

jeromy-cannon deleted the 00977-reduce-redundancy-on-context-to-cluster-flags-in-solo-deployment-create branch January 24, 2025 16:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(cli): reduce redundancy on context to cluster flags in command `deployment create` #1156

feat(cli): reduce redundancy on context to cluster flags in command `deployment create` #1156

instamenta commented Jan 14, 2025

github-actions bot commented Jan 14, 2025 •

edited

Loading

github-actions bot commented Jan 14, 2025 •

edited

Loading

github-actions bot commented Jan 14, 2025 •

edited

Loading

codacy-production bot commented Jan 14, 2025 •

edited

Loading

codecov bot commented Jan 14, 2025 •

edited

Loading

jeromy-cannon left a comment

jeromy-cannon left a comment

feat(cli): reduce redundancy on context to cluster flags in command deployment create #1156

feat(cli): reduce redundancy on context to cluster flags in command deployment create #1156

Conversation

instamenta commented Jan 14, 2025

Description

Related Issues

github-actions bot commented Jan 14, 2025 • edited Loading

Unit Test Results - Linux

github-actions bot commented Jan 14, 2025 • edited Loading

Unit Test Results - Windows

github-actions bot commented Jan 14, 2025 • edited Loading

E2E Test Report

codacy-production bot commented Jan 14, 2025 • edited Loading

Coverage summary from Codacy

See diff coverage on Codacy

See your quality gate settings Change summary preferences

Footnotes

codecov bot commented Jan 14, 2025 • edited Loading

Codecov Report

jeromy-cannon left a comment

Choose a reason for hiding this comment

jeromy-cannon left a comment

Choose a reason for hiding this comment

feat(cli): reduce redundancy on context to cluster flags in command `deployment create` #1156

feat(cli): reduce redundancy on context to cluster flags in command `deployment create` #1156

github-actions bot commented Jan 14, 2025 •

edited

Loading

github-actions bot commented Jan 14, 2025 •

edited

Loading

github-actions bot commented Jan 14, 2025 •

edited

Loading

codacy-production bot commented Jan 14, 2025 •

edited

Loading

codecov bot commented Jan 14, 2025 •

edited

Loading